You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tmaier@mapreal19 I think this was suggested in the past already? I don't remember if there was a reason for keeping the lock file tracked, otherwise it should be much easier to work like this.
The guideline for Gems says not to commit the lockfile. Even to add lockfile false to the Gemfile. I'd follow the best practice here, plus the 7 days cooldown @mapreal19 suggests
OK so in an ideal world I'd set lockfile false in the Gemfile but the bundler cache used by CI depends on the lockfile. So I think git-ignoring it is fine for now. I'm also adding the cooldown 7 (you can override it from the command line).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tmaier @mapreal19 I think this was suggested in the past already? I don't remember if there was a reason for keeping the lock file tracked, otherwise it should be much easier to work like this.